Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Cadence v1.3.0 #6779

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update to Cadence v1.3.0 #6779

wants to merge 7 commits into from

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Dec 3, 2024 •
edited
Loading

Description

Automatically update to:

Required for #6761

@turbolent turbolent requested a review from Kay-Zee as a code owner December 3, 2024 23:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.44304% with 102 lines in your changes missing coverage. Please review.

Project coverage is 40.91%. Comparing base (a3c2cea) to head (43ae10b).

Files with missing lines Patch % Lines
cmd/util/ledger/migrations/cadence_value_diff.go 31.70% 54 Missing and 2 partials ⚠️
cmd/util/cmd/check-storage/cmd.go 0.00% 23 Missing ⚠️
...il/cmd/check-storage/evm_account_storage_health.go 52.17% 10 Missing and 1 partial ⚠️
cmd/util/cmd/generate-authorization-fixes/cmd.go 0.00% 3 Missing ⚠️
.../migrations/filter_unreferenced_slabs_migration.go 75.00% 2 Missing and 1 partial ⚠️
cmd/util/cmd/checkpoint-collect-stats/cmd.go 0.00% 2 Missing ⚠️
...md/util/ledger/reporters/fungible_token_tracker.go 80.00% 1 Missing and 1 partial ⚠️
cmd/util/cmd/diff-states/cmd.go 0.00% 1 Missing ⚠️
cmd/util/ledger/util/atree_util.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6779      +/-   ##
==========================================
- Coverage   41.08%   40.91%   -0.17%     
==========================================
  Files        2121     2082      -39     
  Lines      185905   182075    -3830     
==========================================
- Hits        76373    74492    -1881     
+ Misses     103118   101331    -1787     
+ Partials     6414     6252     -162
Flag Coverage Δ
unittests 40.91% <35.44%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested review from a team and fxamacker December 3, 2024 23:31
@turbolent turbolent mentioned this pull request Dec 3, 2024
Open
@turbolent
Copy link
Member Author

turbolent commented Dec 4, 2024 •
edited
Loading

Unrelated tests are failing:

  1. TestProtocolStateEntry_Copy: https://github.com/onflow/flow-go/actions/runs/12150438470/job/33883222502?pr=6779#step:6:1848
  2. TestProxyAccessAPI: https://github.com/onflow/flow-go/actions/runs/12150438470/job/33883218206?pr=6779#step:6:39033

Can you PTAL at 1. @durkmurder @jordanschalm @AlexHentschel, and 2. @peterargue 🙏

Could be caused by the version bump of the test assertion library, github.com/stretchr/testify from v1.9.0 to v1.10.0, specifically stretchr/testify#1661 / stretchr/testify#1664

@jordanschalm
remove NotSame assertion
662fc0d 
NotSame checks pointer inequality; the input was not a pointer. This
caused a failure once testify was updated to explicitly catch and throw
an error in this case.
@jordanschalm
Copy link
Member

@turbolent Pushed 662fc0d to address (1). Thanks for linking the testify changes 🙇.

fxamacker
fxamacker approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @turbolent for updating to Cadence v1.3.0! 🎉

@turbolent turbolent requested a review from peterargue December 12, 2024 17:27
@turbolent turbolent enabled auto-merge December 18, 2024 22:26
@turbolent
Copy link
Member Author

@onflow/flow-access Could you please take another look at the failing AN test?

@peterargue peterargue mentioned this pull request Jan 17, 2025
Merged
@turbolent turbolent requested a review from a team as a code owner January 17, 2025 20:56
@turbolent
Copy link
Member Author

turbolent commented Jan 17, 2025 •
edited
Loading

@onflow/flow-cadence-execution

I just merged flow-go master into #6779 and am seeing a couple new unit test failures for engine/execution, see https://github.com/onflow/flow-go/actions/runs/12836724195/job/35799063596?pr=6779:

  • TestFailedTxWillNotChangeStateCommitment: Condition never satisfied
  • TestTransactionFeeDeduction: implementation error in derived data cache: expected program missing in cache for location: f8d6e0586b0a20c7.FlowStorageFees

Can someone familiar with these please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@fxamacker fxamacker fxamacker approved these changes

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee

@peterargue peterargue Awaiting requested review from peterargue

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing zhangchiqing is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@turbolent @codecov-commenter @jordanschalm @fxamacker @janezpodhostnik